Issue 1287003006: Fix task dependency graph computation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1287003006: Fix task dependency graph computation. (Closed)

Created:
5 years, 4 months ago by Paul Berry

Modified:
5 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix task dependency graph computation. Previously, when analyzing the analyzer for task dependency graph computation, we failed to canonicalize Source URIs into "package:" URIs. As a result, we failed to properly connect the classes representing individual classes with the base class AnalysisTask, so we couldn't find any task classes and produced an empty graph. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/94471ea0a308691ccdf97c3a39ae080b56b9df43

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	pkg/analyzer/tool/task_dependency_graph.dart	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 4 months ago (2015-08-12 21:46:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
94471ea0a308691ccdf97c3a39ae080b56b9df43 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages