Issue 12870003: Make argument to StringSink.writeln optional.

Issue 12870003: Make argument to StringSink.writeln optional. (Closed)

Created:
7 years, 9 months ago by floitsch

Modified:
7 years, 9 months ago

Reviewers:
Lasse Reichstein Nielsen, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make argument to StringSink.writeln optional. BUG= http://dartbug.com/9102 First part: Committed: https://code.google.com/p/dart/source/detail?r=20074 Second part (one liner): Committed: https://code.google.com/p/dart/source/detail?r=20081

Patch Set 2 : Forgot one use-case. #

Total comments: 2

Patch Set 4 : Minor fix. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	pkg/http/test/safe_http_server.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/test/metatest.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/code_buffer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/string_buffer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/string_sink.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/io_sink.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/http.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/pub/safe_http_server.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

dbc https://codereview.chromium.org/12870003/diff/3001/utils/pub/http.dart File utils/pub/http.dart (right): https://codereview.chromium.org/12870003/diff/3001/utils/pub/http.dart#newcode94 utils/pub/http.dart:94: requestLog.write(''); writeln()?

7 years, 9 months ago (2013-03-15 11:10:53 UTC) #3

floitsch

https://chromiumcodereview.appspot.com/12870003/diff/3001/utils/pub/http.dart File utils/pub/http.dart (right): https://chromiumcodereview.appspot.com/12870003/diff/3001/utils/pub/http.dart#newcode94 utils/pub/http.dart:94: requestLog.write(''); On 2013/03/15 11:10:53, Søren Gjesse wrote: > writeln()? ...

7 years, 9 months ago (2013-03-15 12:45:21 UTC) #4

floitsch

7 years, 9 months ago (2013-03-15 13:59:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r20081 (presubmit successful).

Expand Messages | Collapse Messages