Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286993004: Split resolution into several libraries. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1495 lines, -1139 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +38 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +39 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/label_scope.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/member_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +65 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/operators.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 2 chunks +34 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1016 lines, -67 lines 1 comment Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +19 lines, -962 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/scope.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/secret_tree_element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +3 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +20 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +32 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 2 chunks +21 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 3 chunks +35 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +28 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/variables.dart View 1 chunk +21 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +14 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 6 chunks +11 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-12 13:24:05 UTC) #2
Johnni Winther
Main changes in resolution/*.dart. https://codereview.chromium.org/1286993004/diff/1/pkg/compiler/lib/src/resolution/resolution.dart File pkg/compiler/lib/src/resolution/resolution.dart (right): https://codereview.chromium.org/1286993004/diff/1/pkg/compiler/lib/src/resolution/resolution.dart#newcode60 pkg/compiler/lib/src/resolution/resolution.dart:60: The rest of the file ...
5 years, 4 months ago (2015-08-17 08:01:34 UTC) #3
Siggi Cherem (dart-lang)
Thanks Johnni, sorry for the delay - lgtm!
5 years, 4 months ago (2015-08-17 16:59:49 UTC) #4
Johnni Winther
5 years, 4 months ago (2015-08-18 08:46:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
00df363b7af4ea8b0178c7d1f32cb8a01be33254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698