Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1286993003: dart2js cps: Improve rewriting of == to identical. (Closed)

Created:
5 years, 4 months ago by asgerf
Modified:
5 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Improve rewriting of == to identical. We now rewrite `x == y` if x is known to have a == implementation that corresponds to identical(). Previously it would only do this when x was num, string, or bool. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/703e968620ff990127a77bcfd25e2846573c82c4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +22 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
asgerf
https://codereview.chromium.org/1286993003/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1286993003/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode890 pkg/compiler/lib/src/cps_ir/type_propagation.dart:890: if (left.isNullConstant || right.isNullConstant) { The check on left ...
5 years, 4 months ago (2015-08-12 09:34:06 UTC) #2
karlklose
LGTM!
5 years, 4 months ago (2015-08-12 10:00:28 UTC) #3
asgerf
5 years, 4 months ago (2015-08-12 11:13:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
703e968620ff990127a77bcfd25e2846573c82c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698