Issue 1286823003: Fix issue 24043: do not trust the pattern. Enable a 'hidden' test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1286823003: Fix issue 24043: do not trust the pattern. Enable a 'hidden' test. (Closed)

Created:
5 years, 4 months ago by srdjan

Modified:
5 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix issue 24043: do not trust the pattern. Enable a 'hidden' test. If there is a performance issues, I can add specialized code for String patterns. BUG=24043 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/56c91201c32b8213d37849e22dbabf392eef1bd6

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -101 lines)			Patch
M	runtime/lib/string_patch.dart	View		2 chunks	+5 lines, -3 lines	0 comments	Download
D	tests/language/string_interpolation_and_buffer.dart	View		1 chunk	+0 lines, -98 lines	0 comments	Download
A +	tests/language/string_interpolation_and_buffer_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/language/string_split_test.dart	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

srdjan

5 years, 4 months ago (2015-08-11 21:46:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
56c91201c32b8213d37849e22dbabf392eef1bd6 (presubmit successful).