Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 1286713002: Don't expect analyzer to fail resource tests. (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't expect analyzer to fail resource tests. Also make package have `publish_to:"none"` on pubspec. R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/8301c6e7b2e81139c8b75186f8d2e0c0514f672a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/package_test_data/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-11 09:21:25 UTC) #2
Søren Gjesse
lgtm
5 years, 4 months ago (2015-08-11 09:30:50 UTC) #3
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-11 09:35:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8301c6e7b2e81139c8b75186f8d2e0c0514f672a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698