Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 12866005: Add a function for finding the HTTP proxy server from environment variables (Closed)

Created:
7 years, 9 months ago by Søren Gjesse
Modified:
7 years, 9 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a function for finding the HTTP proxy server from environment variables R=ager@google.com BUG=https://code.google.com/p/dart/issues/detail?id=5468 Committed: https://code.google.com/p/dart/source/detail?r=20202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -0 lines) Patch
M sdk/lib/io/http.dart View 1 chunk +54 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +50 lines, -0 lines 0 comments Download
A tests/standalone/io/http_proxy_configuration_test.dart View 1 chunk +59 lines, -0 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 3 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 9 months ago (2013-03-19 12:47:43 UTC) #1
Mads Ager (google)
LGTM
7 years, 9 months ago (2013-03-19 12:54:11 UTC) #2
Søren Gjesse
7 years, 9 months ago (2013-03-19 13:00:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698