Issue 12865004: Fix DART_CHECK_VALID macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12865004: Fix DART_CHECK_VALID macro. (Closed)

Created:
7 years, 9 months ago by podivilov

Modified:
7 years, 9 months ago

Reviewers:
turnidge, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix DART_CHECK_VALID macro. DART_CHECK_VALID(expression) currently evaluates the exression twice in case of an error. For expressions with side effects it might result in a misleading message. R=turnidge@google.com,asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=20146

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	runtime/include/dart_api.h	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

podivilov

7 years, 9 months ago (2013-03-18 09:34:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20146 (presubmit successful).