Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286493004: Remove --compile_all from all but one service test (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove --compile_all from all but one service test BUG= Committed: https://github.com/dart-lang/sdk/commit/e577dd8438f3dfa43341a13e72d53b9fe51533cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -52 lines) Patch
M runtime/observatory/tests/service/allocations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/async_continuation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/async_generator_breakpoint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/async_next_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/async_scope_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/bad_web_socket_address_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/break_on_activation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/break_on_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/caching_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/command_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/coverage_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugger_inspect_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugger_location_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugging_inlined_finally_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/dominator_tree_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/echo_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/evaluate_activation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/gc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_allocation_samples_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_flag_list_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_heap_map_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_instances_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_isolate_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_ports_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_retained_size_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_retaining_path_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_version_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_vm_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/graph_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/inbound_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/isolate_lifecycle_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/library_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/malformed_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/mirror_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/native_metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/pause_on_exceptions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/read_stream_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/set_library_debuggable_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/steal_breakpoint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/string_escaping_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/type_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/typed_data_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/weak_properties_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
turnidge
lgtm
5 years, 4 months ago (2015-08-10 21:20:07 UTC) #2
Cutch
5 years, 4 months ago (2015-08-10 21:20:10 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e577dd8438f3dfa43341a13e72d53b9fe51533cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698