Make Dart2js implement the onExit/onError/errorsAreFatal parameters to spawnUri.

Make Dart2js implement the onExit/onError/errorsAreFatal parameters to spawnUri.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/5fa70c4220fb70fb20f2010fcb1c7466aa1fc71c

[Lasse Reichstein Nielsen, 2015-08-14 10:58:19]

lrn@google.com changed reviewers:
+ sigmund@google.com

[Lasse Reichstein Nielsen, 2015-08-14 10:58:19]

This can be optimized by sending the parameters along with the spawn request,
but for now this implements the desired behavior.

[Siggi Cherem (dart-lang), 2015-08-14 16:53:28]

lgtm - Thanks Lasse!

https://codereview.chromium.org/1286193006/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/1286193006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:45: (onExit         != null)
||
nit: no need to align the operators. I hope to start using the formatter on
these files in the future too.

This got me thinking, now that we have ?? this could be:

  bool forcePause = (errorsAreFatal ?? onExit ?? onError) != null;

No need to changed it though, the current expression is probably easier to
understand.

https://codereview.chromium.org/1286193006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:63: if (errorsAreFatal !=
null) {
could you add a TODO here just indicating what you mentioned in the message of
the CL (that we should be passing the values directly in the spawn call instead)

[Lasse Reichstein Nielsen, 2015-08-18 07:56:35]

https://codereview.chromium.org/1286193006/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/1286193006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:45: (onExit         != null)
||
> nit: no need to align the operators. I hope to start using the formatter on
these files in the future too.

Your code, your choice :) 
Until the formatter starts to align things instead of removing alignment, I
don't think I'll use it.

 
> This got me thinking, now that we have ?? this could be:
> 
>   bool forcePause = (errorsAreFatal ?? onExit ?? onError) != null;
> 
> No need to changed it though, the current expression is probably easier to
> understand.

Absolutely. I still can't remember what ?? means.

https://codereview.chromium.org/1286193006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:63: if (errorsAreFatal !=
null) {
On 2015/08/14 16:53:28, Siggi Cherem (dart-lang) wrote:
> could you add a TODO here just indicating what you mentioned in the message of
> the CL (that we should be passing the values directly in the spawn call
instead)

Done.

[Lasse Reichstein Nielsen, 2015-08-18 07:56:46]

Committed patchset #2 (id:20001) manually as
5fa70c4220fb70fb20f2010fcb1c7466aa1fc71c (presubmit successful).