Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286143003: Move diagnostic_listener.dart and messages.dart to the diagnostics folder (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move diagnostic_listener.dart and messages.dart to the diagnostics folder BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/930bc75c0d36abe13c9b63c6522e1b3fd2ff6ddc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -3509 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D pkg/compiler/lib/src/diagnostic_listener.dart View 1 chunk +0 lines, -40 lines 0 comments Download
A + pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 2 chunks +3 lines, -3 lines 0 comments Download
D pkg/compiler/lib/src/messages.dart View 1 chunk +0 lines, -3355 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scannerlib.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/duplicate_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/erroneous_element_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/import_mirrors_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/library_resolution_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/missing_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/package_root_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/part_of_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/private_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-12 09:59:53 UTC) #2
karlklose
LGTM.
5 years, 4 months ago (2015-08-12 10:01:16 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-12 10:06:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
930bc75c0d36abe13c9b63c6522e1b3fd2ff6ddc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698