Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286123005: dart2js cps: Bugfixes in .push rewrites. (Closed)

Created:
5 years, 4 months ago by asgerf
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Bugfixes in .push rewrites. Two consecutive pushes would sometimes be merged in a way that one of the arguments could fall out of scope. List.addAll with a literal list as argument would sometimes be rewritten to a push, even though the list could be modified before the use. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/c659bda53b5561978d9c73c489031cf64e613d70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 4 months ago (2015-08-14 09:53:21 UTC) #2
Kevin Millikin (Google)
LGTM.
5 years, 4 months ago (2015-08-14 10:06:24 UTC) #3
asgerf
5 years, 4 months ago (2015-08-14 10:07:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c659bda53b5561978d9c73c489031cf64e613d70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698