Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1286113003: dart2js cps: Fix treatment of captured type variables. (Closed)

Created:
5 years, 4 months ago by asgerf
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Fix treatment of captured type variables. CLOSES=24064 BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/0210c5c035c0cb2aa8cf379abbce88ffee1e6f54

Patch Set 1 #

Patch Set 2 : Update comment #

Patch Set 3 : Tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 1 chunk +11 lines, -5 lines 0 comments Download
M pkg/pkg.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 4 months ago (2015-08-13 11:18:45 UTC) #2
Kevin Millikin (Google)
Super. LGTM.
5 years, 4 months ago (2015-08-13 11:34:10 UTC) #3
asgerf
5 years, 4 months ago (2015-08-13 11:35:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0210c5c035c0cb2aa8cf379abbce88ffee1e6f54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698