Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285993002: Fix android DEBUG build. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
Cutch, eseidel
CC:
eseidel1, reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Revert TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/thread_interrupter_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
koda
5 years, 4 months ago (2015-08-11 23:06:56 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-11 23:07:42 UTC) #3
koda
Committed patchset #2 (id:20001) manually as c756f9dade8cba4913935b27703d7307c7e76401 (presubmit successful).
5 years, 4 months ago (2015-08-11 23:08:00 UTC) #4
eseidel
For what it's worth, I was seeing this in both release and debug. Maybe we're ...
5 years, 4 months ago (2015-08-11 23:09:25 UTC) #6
Cutch
On 2015/08/11 23:09:25, eseidel wrote: > For what it's worth, I was seeing this in ...
5 years, 4 months ago (2015-08-11 23:11:33 UTC) #7
koda
On 2015/08/11 23:11:33, Cutch wrote: > On 2015/08/11 23:09:25, eseidel wrote: > > For what ...
5 years, 4 months ago (2015-08-11 23:16:20 UTC) #8
Cutch
5 years, 4 months ago (2015-08-11 23:19:31 UTC) #9
Message was sent while issue was closed. 
On 2015/08/11 23:16:20, koda wrote:
> On 2015/08/11 23:11:33, Cutch wrote:
> > On 2015/08/11 23:09:25, eseidel wrote:
> > > For what it's worth, I was seeing this in both release and debug.  Maybe
> we're
> > > building Dart with a DEBUG flag even in release?
> > 
> > Based on this, it is likely that you are :(
> > 
> > I can take a look tomorrow morning.
> 
> Not necessarily. Release mode should still complain about 'result' being
> undefined, since it's an ASSERT rather than a DEBUG_ASSERT.
> 
> The real question is why this didn't fail on any of our bots.

In the runtime, ASSERT only runs in DEBUG mode.

Powered by Google App Engine
This is Rietveld 408576698