Issue 1285603004: Add Thread-based constructors to TimerScope, TimelineDurationScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1285603004: Add Thread-based constructors to TimerScope, TimelineDurationScope. (Closed)

Created:
5 years, 4 months ago by koda

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add Thread-based constructors to TimerScope, TimelineDurationScope. Prepares for helper threads being able to allocate/invoke GC. Also synchronize access to Heap::gc_in_progress_. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f78fcffcfd393f0456f65bd211aa6e28c9af9cef

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -15 lines)			Patch
M	runtime/vm/heap.h	View	1	3 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/heap.cc	View	1 2	6 chunks	+34 lines, -14 lines	0 comments	Download
M	runtime/vm/timeline.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/timer.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

koda

5 years, 4 months ago (2015-08-10 22:24:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
f78fcffcfd393f0456f65bd211aa6e28c9af9cef (presubmit successful).