suggest "in" in for statement

suggest "in" in for statement

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/3bbf03ba7ba5bddb89ccc9237ca47b2ca55d7548

[danrubel, 2015-08-10 12:44:07]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-08-10 13:56:18]

LGTM

https://codereview.chromium.org/1285573003/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
(right):

https://codereview.chromium.org/1285573003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/keyword_contributor_test.dart:520:
test_for_expression_in() {
It would be good to have some negative tests here as well to ensure that we
don't suggest 'in' in a normal for loop, such as

for (int j = i^; j < length; j++) {}

https://codereview.chromium.org/1285573003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/keyword_contributor_test.dart:526:
test_for_expression_in2() {
I'm not sure what the utility is of suggesting 'in' after the user types 'in'...

[danrubel, 2015-08-10 14:42:25]

https://codereview.chromium.org/1285573003/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/completion/keyword_contributor_test.dart
(right):

https://codereview.chromium.org/1285573003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/keyword_contributor_test.dart:520:
test_for_expression_in() {
On 2015/08/10 13:56:18, Brian Wilkerson wrote:
> It would be good to have some negative tests here as well to ensure that we
> don't suggest 'in' in a normal for loop, such as
> 
> for (int j = i^; j < length; j++) {}

Good point. Added additional tests and handled new situation. Happy to address
any issues you find with the new code in a subsequent CL.

https://codereview.chromium.org/1285573003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/keyword_contributor_test.dart:526:
test_for_expression_in2() {
On 2015/08/10 13:56:18, Brian Wilkerson wrote:
> I'm not sure what the utility is of suggesting 'in' after the user types
'in'...

It's good to ensure "in" is in the list of suggestions so that we don't
auto-insert something else when the user wanted "in".

[danrubel, 2015-08-10 14:43:32]

Committed patchset #3 (id:40001) manually as
3bbf03ba7ba5bddb89ccc9237ca47b2ca55d7548 (presubmit successful).