Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1285293004: Migrate most uses of StackZone(Isolate*) to Thread*. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate most uses of StackZone(Isolate*) to Thread*. Also migrate some HANDLESCOPE uses. This prepares for concurrent compilation. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/bc149bf2f5105c6d117b5a12fcdc0a8b45a39d16

Patch Set 1 #

Patch Set 2 : Unit tests. #

Patch Set 3 : Final cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -64 lines) Patch
M runtime/vm/benchmark_test.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 3 chunks +11 lines, -9 lines 0 comments Download
M runtime/vm/compiler.cc View 9 chunks +16 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/gc_marker.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/native_entry.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/runtime_entry.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot_test.cc View 25 chunks +25 lines, -25 lines 0 comments Download
M runtime/vm/unit_test.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/zone_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 4 months ago (2015-08-12 23:01:55 UTC) #2
siva
lgtm
5 years, 4 months ago (2015-08-13 19:27:40 UTC) #3
koda
5 years, 4 months ago (2015-08-13 20:11:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bc149bf2f5105c6d117b5a12fcdc0a8b45a39d16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698