Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 12851019: Fixed the first issue in debug_lib.dart (Closed)

Created:
7 years, 9 months ago by kustermann
Modified:
7 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixed the first issue in debug_lib.dart Committed: https://code.google.com/p/dart/source/detail?r=20520

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M tests/standalone/debugger/debug_lib.dart View 4 chunks +2 lines, -11 lines 1 comment Download
M tests/standalone/standalone.status View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 9 months ago (2013-03-26 15:44:09 UTC) #1
Ivan Posva
LGTM with comment. -Ivan https://codereview.chromium.org/12851019/diff/1/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/12851019/diff/1/tests/standalone/debugger/debug_lib.dart#newcode513 tests/standalone/debugger/debug_lib.dart:513: showDebuggeeOutput = !options.arguments.contains("--non-verbose"); --no-verbose https://codereview.chromium.org/12851019/diff/1/tests/standalone/standalone.status ...
7 years, 9 months ago (2013-03-26 15:58:38 UTC) #2
kustermann
https://codereview.chromium.org/12851019/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/12851019/diff/1/tests/standalone/standalone.status#newcode17 tests/standalone/standalone.status:17: debugger/basic_debugger_test: Pass, Fail, Timeout On 2013/03/26 15:58:38, Ivan Posva ...
7 years, 9 months ago (2013-03-26 16:01:20 UTC) #3
kustermann
7 years, 9 months ago (2013-03-26 16:01:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698