Issue 12851013: Adding web_gl library.

Issue 12851013: Adding web_gl library. (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding web_gl library. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20833

Patch Set 3 : sync to tot #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4494 lines, -3535 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		5 chunks	+2 lines, -1674 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		5 chunks	+2 lines, -1834 lines	0 comments	Download
A	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	1 2	1 chunk	+1989 lines, -0 lines	0 comments	Download
A	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View	1 2	1 chunk	+2149 lines, -0 lines	0 comments	Download
M	tests/html/webgl_1_test.dart	View		1 chunk	+22 lines, -20 lines	0 comments	Download
M	tools/create_sdk.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/scripts/dartdomgenerator.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
A	tools/dom/src/WebGLConstants.dart	View		1 chunk	+302 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A +	tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A +	tools/dom/templates/html/dartium/web_gl_dartium.darttemplate	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/12851013/diff/5001/tools/dom/scripts/dartdomgenerator.py File tools/dom/scripts/dartdomgenerator.py (right): https://codereview.chromium.org/12851013/diff/5001/tools/dom/scripts/dartdomgenerator.py#newcode32 tools/dom/scripts/dartdomgenerator.py:32: _libraries = ['chrome', 'web_gl', 'html', 'indexed_db', 'svg', 'web_audio', ...

7 years, 9 months ago (2013-03-20 01:59:39 UTC) #2

blois

7 years, 8 months ago (2013-04-03 00:45:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r20833 (presubmit successful).

Expand Messages | Collapse Messages