Issue 12850010: Add FileSystemEntity.identical, to test if two file system objects are the same.

Issue 12850010: Add FileSystemEntity.identical, to test if two file system objects are the same. (Closed)

Created:
7 years, 9 months ago by Bill Hesse

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add FileSystemEntity.identical, to test if two file system objects are the same. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20307

Patch Set 2 : Fix windows errors #

Patch Set 3 : Improve posix versions #

Total comments: 2

Patch Set 4 : Change argument names from file1, file2 to path1, path2. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -2 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/bin/file.cc	View	1 2 3	1 chunk	+28 lines, -2 lines	0 comments	Download
M	runtime/bin/file_android.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/file_system_entity_patch.dart	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/file_win.cc	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	1 2 3	3 chunks	+19 lines, -0 lines	0 comments	Download
M	tests/standalone/io/link_test.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm with comments https://codereview.chromium.org/12850010/diff/4001/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/12850010/diff/4001/sdk/lib/io/file_system_entity.dart#newcode45 sdk/lib/io/file_system_entity.dart:45: I think we need a doc ...

7 years, 9 months ago (2013-03-20 07:49:45 UTC) #2

Bill Hesse

7 years, 9 months ago (2013-03-21 09:45:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r20307 (presubmit successful).

Expand Messages | Collapse Messages