Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1284983004: Also generate error when autogenerating stack traces (fix #25) (Closed)

Created:
5 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/logging.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Also generate error when autogenerating stack traces (fix #25) R=jakemac@google.com Committed: https://github.com/dart-lang/logging/commit/4c2e9fd8b6c88d9529f72808f9c5ac4db8ec732a

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/logging.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/logging_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-15 03:34:32 UTC) #3
jakemac
lgtm lgtm!
5 years, 4 months ago (2015-08-19 19:37:55 UTC) #5
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-19 19:40:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
4c2e9fd8b6c88d9529f72808f9c5ac4db8ec732a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698