Issue 1284873002: VM: Use const instead of final for constants in runtime libraries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1284873002: VM: Use const instead of final for constants in runtime libraries. (Closed)

Created:
5 years, 4 months ago by Florian Schneider

Modified:
5 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Use const instead of final for constants in runtime libraries. It does not make a difference for optimized code (final does not help in optimized code either btw), but allows using those constants directly in unoptimized code. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/b19d518edef331147e5ea70291d329a87ae569fb

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	runtime/lib/date_patch.dart	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/lib/double.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/math_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

5 years, 4 months ago (2015-08-12 07:40:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b19d518edef331147e5ea70291d329a87ae569fb (presubmit successful).