Issue 1284713003: Refactor VMTagScope to Thread* rather than Isolate*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1284713003: Refactor VMTagScope to Thread* rather than Isolate*. (Closed)

Created:
5 years, 4 months ago by koda

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Refactor VMTagScope to Thread* rather than Isolate*. Prepares for per-thread vm tags, but only changes the interface for now. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/ecccff256617760337c84cb85d7e4b1b2225372e

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -27 lines)			Patch
M	runtime/vm/compiler.cc	View	5 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/heap.cc	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	runtime/vm/regexp_parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/tags.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/tags.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

koda

5 years, 4 months ago (2015-08-10 17:43:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ecccff256617760337c84cb85d7e4b1b2225372e (presubmit successful).