Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284673003: Move dart2jslib parts into separate libraries. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix try. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+585 lines, -380 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 11 chunks +31 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/closure.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/common.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 3 chunks +6 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +24 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 3 chunks +14 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/diagnostic_listener.dart View 1 chunk +9 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +15 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 6 chunks +49 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 2 chunks +22 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/messages.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/secret_tree_element.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 1 chunk +31 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/scannerlib.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/script.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +13 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +49 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 2 chunks +27 lines, -2 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 3 chunks +10 lines, -4 lines 0 comments Download
M site/try/poi/poi.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/async_await_js_transform_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/call_site_simple_type_inferer_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/class_codegen2_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/class_codegen_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/class_set_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/closure_tracer_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/constant_folding_codeUnitAt_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/dump_info_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/duplicate_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/erroneous_element_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/field_codegen_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/field_type_simple_inferer_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/if_do_while_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/issue13354_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/least_upper_bound_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/library_resolution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer2_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer3_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_keys_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/map_tracer_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +8 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_exports_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/missing_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mixin_constructor_default_parameter_values_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/package_root_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/part_of_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +12 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/preserve_uris_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/private_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/resolution_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization_analysis_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/side_effect_tdiv_regression_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_callers_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field3_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_relations_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +16 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/use_strict_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/world_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
Start by reviewing dart2jslib.dart.
5 years, 4 months ago (2015-08-10 14:01:52 UTC) #2
karlklose
LGTM.
5 years, 4 months ago (2015-08-10 14:11:27 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 4474acf36bb3b7d10a6fcce0c03de499055401e2 (presubmit successful).
5 years, 4 months ago (2015-08-10 14:19:17 UTC) #4
Siggi Cherem (dart-lang)
lgtm, thank you!
5 years, 4 months ago (2015-08-10 16:27:17 UTC) #6
Johnni Winther
5 years, 4 months ago (2015-08-11 07:56:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
dab1aaae45f69f856a6f4eee5978c90fe73a3f58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698