Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1284633002: Remove dartium formula from homebrew updater. (Closed)

Created:
5 years, 4 months ago by Bill Hesse
Modified:
5 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dartium formula from homebrew updater. The dart formula has options --with-dartium and --with-content-shell, and the dartium formula has been showing the deprecation message for months. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/c4f359fd9fedd6bfae0b5966b92072193ede314a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -63 lines) Patch
M tools/apps/update_homebrew/bin/update_homebrew.dart View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
Whether we just delete the formula, or make it report an error, we won't be ...
5 years, 4 months ago (2015-08-10 10:58:25 UTC) #2
Søren Gjesse
Lets delete it. lgtm
5 years, 4 months ago (2015-08-10 13:21:35 UTC) #3
Bill Hesse
5 years, 4 months ago (2015-08-10 13:39:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4f359fd9fedd6bfae0b5966b92072193ede314a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698