Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284593003: Remove dart2jslib.dart (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dart2jslib.dart dart2jslib.dart is deleted compiler.dart is a library containing mainly Compiler other parts of compiler.dart move according to the listing in https://codereview.chromium.org/1280343002/ R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a7c720f61bfe1b4a516a78c4b1887d4abe449de3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1027 lines, -25919 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 5 chunks +23 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/closure.dart View 1 chunk +11 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/common.dart View 3 chunks +14 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +59 lines, -2216 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 3 chunks +35 lines, -2350 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 2 chunks +8 lines, -2493 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +19 lines, -2427 lines 0 comments Download
M pkg/compiler/lib/src/common/tasks.dart View 2 chunks +12 lines, -2462 lines 0 comments Download
M pkg/compiler/lib/src/common/work.dart View 2 chunks +11 lines, -2493 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +124 lines, -876 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +17 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +20 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +10 lines, -7 lines 0 comments Download
D pkg/compiler/lib/src/dart2jslib.dart View 1 chunk +0 lines, -66 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +28 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 1 chunk +14 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/diagnostic_listener.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/code_location.dart View 2 chunks +2 lines, -2433 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/invariant.dart View 2 chunks +7 lines, -2467 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/source_span.dart View 2 chunks +5 lines, -2481 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/spannable.dart View 2 chunks +1 line, -222 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +19 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +22 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 2 chunks +19 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 chunk +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 1 chunk +20 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +12 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +36 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 3 chunks +7 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 3 chunks +15 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +22 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/headers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/messages.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/mirror_renamer/mirror_renamer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors/analyze.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +11 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 chunk +13 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +17 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +17 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +14 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/secret_tree_element.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scannerlib.dart View 2 chunks +9 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/token_map.dart View 2 chunks +3 lines, -2477 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +16 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tracer.dart View 1 chunk +13 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/tree/tree.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 8 chunks +18 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 2 chunks +10 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 chunk +10 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/util/util.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 chunk +1 line, -4 lines 0 comments Download
M site/try/poi/poi.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M site/try/poi/scope_information_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M site/try/src/compiler_isolate.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_backend_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/end2end_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 3 chunks +10 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_custom_element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_dont_inline_deferred_constants_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_emit_type_checks_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_follow_constant_dependencies_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_inline_restrictions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_mirrors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_not_in_main_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/generate_code_with_compile_time_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/in_user_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer_typed_data_length_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_tree_shaking_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors/mirrors_reader_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/source_map_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_mask_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/try/poi/apply_updates_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/try/poi/diff_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/try/web/incremental_compilation_update_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-11 14:20:23 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
5 years, 4 months ago (2015-08-11 16:28:44 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-12 06:43:02 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a7c720f61bfe1b4a516a78c4b1887d4abe449de3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698