dart2js: Also trace instances of Function as closures.

dart2js: Also trace instances of Function as closures.

R=floitsch@google.com
BUG= http://dartbug.com/23873

Committed: https://github.com/dart-lang/sdk/commit/0973b09aa0056558ba7db385ab96418f5ccd6483

Reverted: https://github.com/dart-lang/sdk/commit/47125dd0adab06c5aa800afe60b0e60dd47db6ac

Committed: https://github.com/dart-lang/sdk/commit/4ad2092516377b6e7f33c7d766b3938ac612bdfd

[herhut, 2015-08-10 10:47:44]

This does not fix the bug but at least the compiler now considers the call
method as a target for Function.apply. Still missing is the generation of the
call* stub.

[floitsch, 2015-08-10 15:39:52]

LGTM.

https://codereview.chromium.org/1284463003/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/1284463003/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:683: void
trace(Iterable<FunctionElement> elements,
new line before and after nested functions.

[herhut, 2015-08-11 08:35:21]

https://codereview.chromium.org/1284463003/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/1284463003/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:683: void
trace(Iterable<FunctionElement> elements,
On 2015/08/10 15:39:51, floitsch wrote:
> new line before and after nested functions.

Done.

[herhut, 2015-08-11 08:36:04]

Committed patchset #1 (id:1) manually as
0973b09aa0056558ba7db385ab96418f5ccd6483 (presubmit successful).

[herhut, 2015-08-11 11:00:30]

PTAL

I forgot to take tear-offs of statics into account...

https://codereview.chromium.org/1284463003/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/1284463003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:26: import
'../resolution/resolution.dart'
Rebase noise...

https://codereview.chromium.org/1284463003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:52: import
'../world.dart' show ClassWorld;
Rebase noise...

[floitsch, 2015-08-11 11:41:13]

LGTM.

https://codereview.chromium.org/1284463003/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/1284463003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:741:
Iterable<FunctionElement> elements = info.callees
The static type of the Iterable is Iterable<Element>.
A 'where' returns the same type as the receiver, and info.callees is of type
`Iterable<Element>`.

Either change the type (new List.from), or update the type-argument to the trace
function.

I guess the reason it wasn't a problem so far, is that the callees iterable
silently returned an iterable<dynamic>.

[herhut, 2015-08-12 09:34:41]

https://codereview.chromium.org/1284463003/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/1284463003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:741:
Iterable<FunctionElement> elements = info.callees
On 2015/08/11 11:41:13, floitsch wrote:
> The static type of the Iterable is Iterable<Element>.
> A 'where' returns the same type as the receiver, and info.callees is of type
> `Iterable<Element>`.
> 
> Either change the type (new List.from), or update the type-argument to the
trace
> function.
> 
> I guess the reason it wasn't a problem so far, is that the callees iterable
> silently returned an iterable<dynamic>.

Done.

[herhut, 2015-08-12 09:38:07]

Committed patchset #4 (id:60001) manually as
4ad2092516377b6e7f33c7d766b3938ac612bdfd (presubmit successful).