Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1284393004: Mark resource as experimental (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 4 months ago
Reviewers:
mit, asandholm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use the word "experimental" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sdk/lib/core/resource.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-20 09:15:57 UTC) #2
mit
Anders, can you take a look at this also? https://codereview.chromium.org/1284393004/diff/1/sdk/lib/core/resource.dart File sdk/lib/core/resource.dart (right): https://codereview.chromium.org/1284393004/diff/1/sdk/lib/core/resource.dart#newcode10 sdk/lib/core/resource.dart:10: ...
5 years, 4 months ago (2015-08-20 09:31:42 UTC) #4
asandholm
LGTM - with Michael's comment incorporated.
5 years, 4 months ago (2015-08-20 09:38:50 UTC) #5
Lasse Reichstein Nielsen
https://codereview.chromium.org/1284393004/diff/1/sdk/lib/core/resource.dart File sdk/lib/core/resource.dart (right): https://codereview.chromium.org/1284393004/diff/1/sdk/lib/core/resource.dart#newcode10 sdk/lib/core/resource.dart:10: * WARNING: This API is under development, Interesting. I ...
5 years, 4 months ago (2015-08-20 09:40:15 UTC) #6
mit
https://codereview.chromium.org/1284393004/diff/1/sdk/lib/core/resource.dart File sdk/lib/core/resource.dart (right): https://codereview.chromium.org/1284393004/diff/1/sdk/lib/core/resource.dart#newcode10 sdk/lib/core/resource.dart:10: * WARNING: This API is under development, On 2015/08/20 ...
5 years, 4 months ago (2015-08-20 09:42:53 UTC) #7
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-20 11:59:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1d537028f7cbe026fb682804fb13c72aa3261ae5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698