Issue 1284233003: dart2js CPS: Fix a bug in commuting binary operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1284233003: dart2js CPS: Fix a bug in commuting binary operations. (Closed)

Created:
5 years, 4 months ago by Kevin Millikin (Google)

Modified:
5 years, 4 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js CPS: Fix a bug in commuting binary operations. The Tree IR statement rewriter assumes both operands of a binary operation are variable uses. Either one of them could also be `this`. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/b495fceef8a1d7e9918641073f2638ce3b68ae92

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart	View	1	3 chunks	+14 lines, -11 lines	0 comments	Download

Total messages: 4 (1 generated)

Kevin Millikin (Google)

I hit this when implementing inlining. My simple attempt at a test case didn't trigger ...

5 years, 4 months ago (2015-08-14 10:55:43 UTC) #2

Kevin Millikin (Google)

5 years, 4 months ago (2015-08-17 09:17:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b495fceef8a1d7e9918641073f2638ce3b68ae92 (presubmit successful).