Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1284103008: Clean up code capturing variables explicitly. (Closed)

Created:
5 years, 4 months ago by regis
Modified:
5 years, 4 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : use correct scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M runtime/vm/parser.cc View 1 4 chunks +1 line, -14 lines 0 comments Download
M runtime/vm/scopes.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
5 years, 4 months ago (2015-08-17 22:41:28 UTC) #2
hausner
LGTM
5 years, 4 months ago (2015-08-17 22:47:44 UTC) #3
regis
5 years, 4 months ago (2015-08-17 23:09:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6d6a6a49b64dc83857c39c5f56c5cdccaf616d0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698