Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1284093004: Reuse canonicalized type for receiver type if class is not signature class and has no type paramete… (Closed)

Created:
5 years, 4 months ago by srdjan
Modified:
5 years, 4 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reuse canonicalized type for receiver type if class is not signature class and has no type parameters. BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/5dedcf9d28805b3455708bcd70bcf4c969a3e05f

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 2

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M runtime/vm/parser.cc View 1 2 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 4 months ago (2015-08-19 17:37:30 UTC) #2
hausner
LGTM https://codereview.chromium.org/1284093004/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/1284093004/diff/20001/runtime/vm/parser.cc#newcode11864 runtime/vm/parser.cc:11864: // This requirement is embedded in 'CacnonicalType' function. ...
5 years, 4 months ago (2015-08-19 17:45:03 UTC) #3
srdjan
https://codereview.chromium.org/1284093004/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/1284093004/diff/20001/runtime/vm/parser.cc#newcode11864 runtime/vm/parser.cc:11864: // This requirement is embedded in 'CacnonicalType' function. On ...
5 years, 4 months ago (2015-08-19 17:55:25 UTC) #4
srdjan
5 years, 4 months ago (2015-08-19 17:58:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5dedcf9d28805b3455708bcd70bcf4c969a3e05f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698