Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284063003: Add Regex isCaseSensitive and isMultiLine to the service protocol and Observatory. (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Regex isCaseSensitive and isMultiLine to the service protocol and Observatory. BUG=http://dartbug.com/24039 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/3851c8c0eda48907649193d475737e87192eeee5

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M runtime/observatory/lib/src/elements/instance_view.html View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/get_version_rpc_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service/service.md View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-12 01:42:43 UTC) #2
Cutch
LGTM wC https://codereview.chromium.org/1284063003/diff/20001/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/1284063003/diff/20001/runtime/observatory/lib/src/service/object.dart#newcode2224 runtime/observatory/lib/src/service/object.dart:2224: isCaseSensitive = map['_isCaseSensitive']; these are public keys ...
5 years, 4 months ago (2015-08-13 22:32:36 UTC) #3
rmacnak
https://codereview.chromium.org/1284063003/diff/20001/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/1284063003/diff/20001/runtime/observatory/lib/src/service/object.dart#newcode2224 runtime/observatory/lib/src/service/object.dart:2224: isCaseSensitive = map['_isCaseSensitive']; On 2015/08/13 22:32:36, Cutch wrote: > ...
5 years, 4 months ago (2015-08-13 22:45:21 UTC) #4
rmacnak
Committed patchset #3 (id:40001) manually as 3851c8c0eda48907649193d475737e87192eeee5 (presubmit successful).
5 years, 4 months ago (2015-08-13 22:50:08 UTC) #5
kevmoo
5 years, 4 months ago (2015-08-14 20:15:27 UTC) #6
Message was sent while issue was closed. 
On 2015/08/13 22:50:08, rmacnak wrote:
> Committed patchset #3 (id:40001) manually as
> 3851c8c0eda48907649193d475737e87192eeee5 (presubmit successful).

Ryan: please update the changelog for this. Gracias

Powered by Google App Engine
This is Rietveld 408576698