Issue 12838002: Deprecate Set.isSubsetOf, make Set.containsAll accept iterable.

Issue 12838002: Deprecate Set.isSubsetOf, make Set.containsAll accept iterable. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
Anton Muhin, floitsch, Mads Ager (google)

CC:
reviews_dartlang.org, Anton Muhin

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Deprecate Set.isSubsetOf, make Set.containsAll accept iterable. Committed: https://code.google.com/p/dart/source/detail?r=19985

Patch Set 2 : Updated test expectations. #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -33 lines)			Patch
M	sdk/lib/collection/collections.dart	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	sdk/lib/collection/hash_set.dart	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	sdk/lib/collection/linked_hash_set.dart	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	sdk/lib/core/set.dart	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+3 lines, -0 lines	2 comments	Download
M	tests/co19/co19-compiler.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	2 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #2 manually as r19985 (presubmit successful).

7 years, 9 months ago (2013-03-14 07:12:30 UTC) #3

Mads Ager (google)

https://codereview.chromium.org/12838002/diff/4001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/12838002/diff/4001/sdk/lib/html/dartium/html_dartium.dart#newcode35267 sdk/lib/html/dartium/html_dartium.dart:35267: + static forwardingPrint(String message) native "Utils_forwardingPrint"; This file is ...

7 years, 9 months ago (2013-03-14 07:49:02 UTC) #4

Anton Muhin

7 years, 9 months ago (2013-03-14 08:08:44 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/12838002/diff/4001/sdk/lib/html/dartium/html_...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/12838002/diff/4001/sdk/lib/html/dartium/html_...
sdk/lib/html/dartium/html_dartium.dart:35267: +  static forwardingPrint(String
message) native "Utils_forwardingPrint";
On 2013/03/14 07:49:02, Mads Ager wrote:
> This file is auto-generated and should not be edited by hand.

Chances are I just forgot to run go.sh and Lasse did hence picking up my
changes.  I'll double check what's the current status.

Expand Messages | Collapse Messages