Issue 1283773002: dart2js cps: Do not add identical calls for foreign code conditions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1283773002: dart2js cps: Do not add identical calls for foreign code conditions. (Closed)

Created:
5 years, 4 months ago by asgerf

Modified:
5 years, 4 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/codegen/glue.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	pkg/compiler/lib/src/js_backend/codegen/unsugar.dart	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

karlklose

On 2015/08/10 15:36:53, asgerf wrote: We should aim at not rewriting conditions whenever we know ...

5 years, 4 months ago (2015-08-11 07:35:09 UTC) #3

asgerf

5 years, 4 months ago (2015-08-11 08:46:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1520e40024149bb86f07d0ab203a3cd51dd25120 (presubmit successful).