Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 12837007: Revise duplicate interface check (Closed)

Created:
7 years, 9 months ago by hausner
Modified:
7 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revise duplicate interface check Move check for duplicate interfaces from parser to class finalizer. The parser only compared interfaces by name, which did not work properly for qualified (imported) names. Now the check happens in the class finalizer after types are finalized. Sadly, our test harness does not appear to know how to handle multitests that import libraries. Committed: https://code.google.com/p/dart/source/detail?r=20167

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -88 lines) Patch
M runtime/vm/class_finalizer.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/vm/parser.h View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 4 chunks +19 lines, -81 lines 0 comments Download
M tests/language/class_cycle_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/duplicate_interface_lib.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
A tests/language/duplicate_interface_negative_test.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
A tests/language/duplicate_interface_test.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
Welcome back Srdjan :)
7 years, 9 months ago (2013-03-16 00:55:34 UTC) #1
srdjan
lgtm
7 years, 9 months ago (2013-03-18 17:32:24 UTC) #2
hausner
7 years, 9 months ago (2013-03-18 17:34:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r20167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698