Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1283443004: suggest constructor named param (Closed)

Created:
5 years, 4 months ago by danrubel
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : take 2 #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -43 lines) Patch
M pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart View 5 chunks +59 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/completion/arglist_contributor_test.dart View 12 chunks +54 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 4 months ago (2015-08-07 17:30:19 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-07 17:42:39 UTC) #3
danrubel
5 years, 4 months ago (2015-08-07 18:09:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8ac02a9a2484edecab0112f62fb3ccc3b19023ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698