Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 12833005: Remove kContext node type introduced in r13936 (Closed)

Created:
7 years, 9 months ago by alph
Modified:
7 years, 9 months ago
Reviewers:
yurys, Jakob Kummerow
CC:
v8-dev, loislo
Visibility:
Public.

Description

Remove kContext node type introduced in r13936 It has been decided not to pollute node types with extra values. Committed: 13959

Patch Set 1 #

Patch Set 2 : Made context a kObject #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M include/v8-profiler.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alph
Could you please take a look. Thanks.
7 years, 9 months ago (2013-03-14 15:45:47 UTC) #1
Jakob Kummerow
Superficially LGTM; I'm leaving the functional review to Yury.
7 years, 9 months ago (2013-03-14 16:20:29 UTC) #2
yurys
Alexei, can provide a link to the corresponding WebKit patch that makes the contexts visible ...
7 years, 9 months ago (2013-03-15 07:49:30 UTC) #3
alph
On 2013/03/15 07:49:30, Yury Semikhatsky wrote: > Alexei, can provide a link to the corresponding ...
7 years, 9 months ago (2013-03-15 08:21:01 UTC) #4
yurys
On 2013/03/15 08:21:01, alph wrote: > On 2013/03/15 07:49:30, Yury Semikhatsky wrote: > > Alexei, ...
7 years, 9 months ago (2013-03-15 08:35:06 UTC) #5
alph
On 2013/03/15 08:35:06, Yury Semikhatsky wrote: > On 2013/03/15 08:21:01, alph wrote: > > On ...
7 years, 9 months ago (2013-03-15 11:50:57 UTC) #6
alph
Made it kObject. PTAL.
7 years, 9 months ago (2013-03-15 12:13:05 UTC) #7
yurys
lgtm
7 years, 9 months ago (2013-03-15 12:14:37 UTC) #8
alph
7 years, 9 months ago (2013-03-15 13:07:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r13959 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698