Issue 1283093004: Ensure TimelineEventRingRecorder outputs blocks in increasing time order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1283093004: Ensure TimelineEventRingRecorder outputs blocks in increasing time order (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Ensure TimelineEventRingRecorder outputs blocks in increasing time order BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d4fbd8309e657207760a54e86e1a92c928b435bf

Patch Set 3 : #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -5 lines)			Patch
M	runtime/vm/timeline.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/timeline.cc	View	1	2 chunks	+25 lines, -3 lines	0 comments	Download
M	runtime/vm/timeline_test.cc	View		3 chunks	+42 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

lgtm https://codereview.chromium.org/1283093004/diff/1/runtime/vm/timeline.cc File runtime/vm/timeline.cc (right): https://codereview.chromium.org/1283093004/diff/1/runtime/vm/timeline.cc#newcode425 runtime/vm/timeline.cc:425: // There is no block that isn't empty. ...

5 years, 4 months ago (2015-08-13 21:19:33 UTC) #3

Cutch

5 years, 4 months ago (2015-08-13 21:22:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
d4fbd8309e657207760a54e86e1a92c928b435bf (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1283093004: Ensure TimelineEventRingRecorder outputs blocks in increasing time order (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages