Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1283093002: - Remove the from field from the the Scavenger class. (Closed)

Created:
5 years, 4 months ago by Ivan Posva
Modified:
5 years, 4 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Remove the from field from the the Scavenger class. BUG= R=koda@google.com Committed: https://github.com/dart-lang/sdk/commit/236b72be6607fcae338b6add5e34c57551726266

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M runtime/vm/scavenger.h View 4 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/scavenger.cc View 1 12 chunks +17 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
5 years, 4 months ago (2015-08-11 23:09:20 UTC) #2
koda
LGTM + suggestion https://codereview.chromium.org/1283093002/diff/1/runtime/vm/scavenger.cc File runtime/vm/scavenger.cc (right): https://codereview.chromium.org/1283093002/diff/1/runtime/vm/scavenger.cc#newcode161 runtime/vm/scavenger.cc:161: ASSERT(from_->Contains(RawObject::ToAddr(raw_obj))); You could rearrange and use ...
5 years, 4 months ago (2015-08-12 01:22:33 UTC) #3
Ivan Posva
https://codereview.chromium.org/1283093002/diff/1/runtime/vm/scavenger.cc File runtime/vm/scavenger.cc (right): https://codereview.chromium.org/1283093002/diff/1/runtime/vm/scavenger.cc#newcode161 runtime/vm/scavenger.cc:161: ASSERT(from_->Contains(RawObject::ToAddr(raw_obj))); On 2015/08/12 01:22:33, koda wrote: > You could ...
5 years, 4 months ago (2015-08-14 20:19:32 UTC) #4
Ivan Posva
5 years, 4 months ago (2015-08-14 20:24:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
236b72be6607fcae338b6add5e34c57551726266 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698