Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282883003: Move service extension handler execution to a timer (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -81 lines) Patch
M runtime/vm/service.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M runtime/vm/service.cc View 1 2 chunks +16 lines, -31 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/developer/extension.dart View 1 1 chunk +41 lines, -42 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 4 months ago (2015-08-10 21:25:57 UTC) #2
Ivan Posva
LGTM with changes as discussed. -Ivan https://codereview.chromium.org/1282883003/diff/1/sdk/lib/developer/extension.dart File sdk/lib/developer/extension.dart (right): https://codereview.chromium.org/1282883003/diff/1/sdk/lib/developer/extension.dart#newcode109 sdk/lib/developer/extension.dart:109: bool _invokeExtension(String method, ...
5 years, 4 months ago (2015-08-10 21:40:22 UTC) #3
Cutch
https://codereview.chromium.org/1282883003/diff/1/sdk/lib/developer/extension.dart File sdk/lib/developer/extension.dart (right): https://codereview.chromium.org/1282883003/diff/1/sdk/lib/developer/extension.dart#newcode109 sdk/lib/developer/extension.dart:109: bool _invokeExtension(String method, On 2015/08/10 21:40:21, Ivan Posva wrote: ...
5 years, 4 months ago (2015-08-10 21:56:20 UTC) #4
Cutch
5 years, 4 months ago (2015-08-10 21:56:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5f02eb3c624f8f94babf6b595698d44429e41098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698