Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1282773002: Refactor and clean up AccessSemantics (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -61 lines) Patch
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 6 chunks +14 lines, -42 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 10 chunks +11 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-10 09:56:22 UTC) #2
karlklose
LGTM.
5 years, 4 months ago (2015-08-10 10:31:47 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-10 10:46:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
147698997f3638169442937134ee46a2a8671c1f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698