Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 12827032: Reverting "Adding CORS support to HttpRequest" (Closed)

Created:
7 years, 9 months ago by Emily Fortuna
Modified:
7 years, 9 months ago
Reviewers:
dgrove, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

"Reverting 20336" BUG= Committed: https://code.google.com/p/dart/source/detail?r=20409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -103 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +2 lines, -14 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/html/html.status View 2 chunks +1 line, -1 line 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 2 chunks +37 lines, -59 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 2 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Unclear why this breaks 7 tests on the linux-chrome-csp (csp?) bot, but reverting so we ...
7 years, 9 months ago (2013-03-22 19:36:39 UTC) #1
dgrove
lgtm
7 years, 9 months ago (2013-03-22 19:37:54 UTC) #2
Emily Fortuna
7 years, 9 months ago (2013-03-22 19:38:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698