Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 128263005: Fix 15721: When checking for bad overrides we must eagerly finalize superclasses. (Closed)

Created:
6 years, 11 months ago by srdjan
Modified:
6 years, 11 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen
Visibility:
Public.

Description

Fix 15721: When checking for bad overrides we must eagerly finalize superclasses. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=31628

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/vm/class_finalizer.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
6 years, 11 months ago (2014-01-08 21:34:17 UTC) #1
regis
LGTM
6 years, 11 months ago (2014-01-08 21:36:24 UTC) #2
srdjan
6 years, 11 months ago (2014-01-08 21:45:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r31628 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698