Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1282463002: Reorganize constants/* libraries. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3761 lines) Patch
M pkg/compiler/lib/src/constants/constant_constructors.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 2 chunks +5 lines, -1635 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 2 chunks +4 lines, -1841 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 3 chunks +2 lines, -280 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-07 11:39:41 UTC) #2
karlklose
LGTM.
5 years, 4 months ago (2015-08-07 11:45:17 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-07 11:57:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
62fd661ec5862e46fa63ea5e5ac62c440f1e0872 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698