Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 12824008: Making it easier to run individual HTML tests. (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Making it easier to run individual HTML tests. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20051

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M pkg/unittest/lib/html_config.dart View 1 3 chunks +22 lines, -1 line 0 comments Download
M pkg/unittest/lib/html_individual_config.dart View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
https://codereview.chromium.org/12824008/diff/2001/pkg/unittest/lib/html_individual_config.dart File pkg/unittest/lib/html_individual_config.dart (right): https://codereview.chromium.org/12824008/diff/2001/pkg/unittest/lib/html_individual_config.dart#newcode28 pkg/unittest/lib/html_individual_config.dart:28: if (search != '') { This is a slightly ...
7 years, 9 months ago (2013-03-14 18:02:14 UTC) #1
gram
lgtm https://codereview.chromium.org/12824008/diff/2001/pkg/unittest/lib/html_config.dart File pkg/unittest/lib/html_config.dart (right): https://codereview.chromium.org/12824008/diff/2001/pkg/unittest/lib/html_config.dart#newcode140 pkg/unittest/lib/html_config.dart:140: filterTests('^${parts[1]}'); This is cool, but can you add ...
7 years, 9 months ago (2013-03-14 18:39:08 UTC) #2
blois
https://codereview.chromium.org/12824008/diff/2001/pkg/unittest/lib/html_config.dart File pkg/unittest/lib/html_config.dart (right): https://codereview.chromium.org/12824008/diff/2001/pkg/unittest/lib/html_config.dart#newcode140 pkg/unittest/lib/html_config.dart:140: filterTests('^${parts[1]}'); On 2013/03/14 18:39:08, gram wrote: > This is ...
7 years, 9 months ago (2013-03-14 21:37:18 UTC) #3
blois
7 years, 9 months ago (2013-03-14 21:38:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20051 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698