Chromium Code Reviews

Issue 1282083002: Generate the package spec from the lockfile. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate the package spec from the lockfile. The spec doesn't actually need all the data loaded from the package graph; all it needs are the locations of packages which can be looked up using their IDs and a SourceRegistry. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/63ad514857c82f58fbc34589b0bca808958e17d8

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Stats (+28 lines, -65 lines)
M lib/src/entrypoint.dart View 2 chunks +1 line, -2 lines 0 comments
M lib/src/global_packages.dart View 2 chunks +1 line, -2 lines 0 comments
M lib/src/lock_file.dart View 2 chunks +26 lines, -0 lines 4 comments
D lib/src/package_locations.dart View 1 chunk +0 lines, -61 lines 0 comments

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 4 months ago (2015-08-07 22:24:48 UTC) #1
Bob Nystrom
https://codereview.chromium.org/1282083002/diff/1/lib/src/lock_file.dart File lib/src/lock_file.dart (right): https://codereview.chromium.org/1282083002/diff/1/lib/src/lock_file.dart#newcode164 lib/src/lock_file.dart:164: Dart tools, including the Dart VM and Dart analyzer, ...
5 years, 4 months ago (2015-08-07 23:51:26 UTC) #2
nweiz
https://codereview.chromium.org/1282083002/diff/1/lib/src/lock_file.dart File lib/src/lock_file.dart (right): https://codereview.chromium.org/1282083002/diff/1/lib/src/lock_file.dart#newcode164 lib/src/lock_file.dart:164: Dart tools, including the Dart VM and Dart analyzer, ...
5 years, 4 months ago (2015-08-08 00:52:57 UTC) #3
Bob Nystrom
lgtm
5 years, 4 months ago (2015-08-10 16:03:24 UTC) #4
nweiz
5 years, 4 months ago (2015-08-10 19:46:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
63ad514857c82f58fbc34589b0bca808958e17d8 (presubmit successful).

Powered by Google App Engine