Issue 128203002: Fix static warnings introduced by library cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128203002: Fix static warnings introduced by library cleanup. (Closed)

Created:
6 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix static warnings introduced by library cleanup. Changing a void function body from "{ foo(); }" to "=> foo()" is not safe. The return value of foo may be incompatible with void. A temporary variable can also be a necessary cast. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31606

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	sdk/lib/io/secure_server_socket.dart	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

We should have caught this in the review :)

6 years, 11 months ago (2014-01-08 12:57:30 UTC) #3

Lasse Reichstein Nielsen

Committed patchset #1 manually as r31606 (presubmit successful).

6 years, 11 months ago (2014-01-08 12:58:49 UTC) #4

vicb

6 years, 11 months ago (2014-01-09 08:43:27 UTC) #5

Message was sent while issue was closed.

On 2014/01/08 12:58:49, Lasse Reichstein Nielsen wrote:
> Committed patchset #1 manually as r31606 (presubmit successful).

Oops ! 
Thanks for the fixes.

Expand Messages | Collapse Messages