Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12812014: Move timer tests to async tests. (Closed)

Created:
7 years, 9 months ago by floitsch
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move timer tests to async tests. Committed: https://code.google.com/p/dart/source/detail?r=20203

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -338 lines) Patch
M tests/isolate/isolate.status View 4 chunks +0 lines, -26 lines 0 comments Download
D tests/isolate/multiple_timer_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/isolate/timer_cancel1_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/isolate/timer_cancel2_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/isolate/timer_cancel_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/isolate/timer_isolate_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/isolate/timer_not_available_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/isolate/timer_repeat_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/isolate/timer_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
A + tests/lib/async/multiple_timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/async/timer_cancel1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/async/timer_cancel2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/async/timer_cancel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/async/timer_isolate_test.dart View 1 chunk +1 line, -1 line 1 comment Download
A + tests/lib/async/timer_not_available_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib/async/timer_repeat_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/async/timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 4 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
https://codereview.chromium.org/12812014/diff/1/tests/lib/async/timer_isolate_test.dart File tests/lib/async/timer_isolate_test.dart (right): https://codereview.chromium.org/12812014/diff/1/tests/lib/async/timer_isolate_test.dart#newcode7 tests/lib/async/timer_isolate_test.dart:7: import 'dart:isolate'; This test could stay in the isolate ...
7 years, 9 months ago (2013-03-15 13:06:41 UTC) #1
Lasse Reichstein Nielsen
lgtm
7 years, 9 months ago (2013-03-19 13:00:54 UTC) #2
floitsch
7 years, 9 months ago (2013-03-19 13:21:17 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r20203 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698