Make LockFile immutable.

Make LockFile immutable.

This also has it store its SourceRegistry, so that various methods don't
need to re-supply it.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/9d02227d02cd9a362233460ed45763436819210e

[Bob Nystrom, 2015-08-07 21:50:56]

https://codereview.chromium.org/1281043004/diff/1/lib/src/global_packages.dart
File lib/src/global_packages.dart (right):

https://codereview.chromium.org/1281043004/diff/1/lib/src/global_packages.dar...
lib/src/global_packages.dart:308: // doesn't expect to be in itw own lockfile.
"itw" -> "its"

https://codereview.chromium.org/1281043004/diff/1/lib/src/lock_file.dart
File lib/src/lock_file.dart (right):

https://codereview.chromium.org/1281043004/diff/1/lib/src/lock_file.dart#newc...
lib/src/lock_file.dart:41: throw new ArgumentError('Undefined source "$source"
for package "$id".');
Long line.

Also, does this do the right thing on old lock files that may still have SDK
sources? Do we care? The rest of pub has the concept of an "unknown" source to
handle this. Should we do that here?

https://codereview.chromium.org/1281043004/diff/1/test/test_pub.dart
File test/test_pub.dart (right):

https://codereview.chromium.org/1281043004/diff/1/test/test_pub.dart#newcode706
test/test_pub.dart:706: lockFile = new LockFile(packages, sources);
This code is a bit grungy. How about adding a method to LockFile that returns a
new LockFile with the package added?

[nweiz, 2015-08-07 22:16:01]

Code review changes

[nweiz, 2015-08-07 22:16:07]

https://codereview.chromium.org/1281043004/diff/1/lib/src/global_packages.dart
File lib/src/global_packages.dart (right):

https://codereview.chromium.org/1281043004/diff/1/lib/src/global_packages.dar...
lib/src/global_packages.dart:308: // doesn't expect to be in itw own lockfile.
On 2015/08/07 21:50:56, Bob Nystrom wrote:
> "itw" -> "its"

Done.

https://codereview.chromium.org/1281043004/diff/1/lib/src/lock_file.dart
File lib/src/lock_file.dart (right):

https://codereview.chromium.org/1281043004/diff/1/lib/src/lock_file.dart#newc...
lib/src/lock_file.dart:41: throw new ArgumentError('Undefined source "$source"
for package "$id".');
On 2015/08/07 21:50:56, Bob Nystrom wrote:
> Long line.

Done.

> Also, does this do the right thing on old lock files that may still have SDK
> sources? Do we care? The rest of pub has the concept of an "unknown" source to
> handle this. Should we do that here?

Removed. I had forgotten about UnknownSource. That means that this will never
return null anyway.

https://codereview.chromium.org/1281043004/diff/1/test/test_pub.dart
File test/test_pub.dart (right):

https://codereview.chromium.org/1281043004/diff/1/test/test_pub.dart#newcode706
test/test_pub.dart:706: lockFile = new LockFile(packages, sources);
On 2015/08/07 21:50:56, Bob Nystrom wrote:
> This code is a bit grungy. How about adding a method to LockFile that returns
a
> new LockFile with the package added?

Done.

[Bob Nystrom, 2015-08-07 22:19:19]

lgtm

https://codereview.chromium.org/1281043004/diff/20001/lib/src/lock_file.dart
File lib/src/lock_file.dart (right):

https://codereview.chromium.org/1281043004/diff/20001/lib/src/lock_file.dart#...
lib/src/lock_file.dart:29: /// Throws an [ArgumentError] if any package has an
undefined source according
Remove the bit about undefined source.

[nweiz, 2015-08-07 22:24:13]

Code review changes

[nweiz, 2015-08-07 22:24:18]

https://codereview.chromium.org/1281043004/diff/20001/lib/src/lock_file.dart
File lib/src/lock_file.dart (right):

https://codereview.chromium.org/1281043004/diff/20001/lib/src/lock_file.dart#...
lib/src/lock_file.dart:29: /// Throws an [ArgumentError] if any package has an
undefined source according
On 2015/08/07 22:19:19, Bob Nystrom wrote:
> Remove the bit about undefined source.

Done.

[nweiz, 2015-08-07 22:24:25]

Committed patchset #3 (id:40001) manually as
9d02227d02cd9a362233460ed45763436819210e (presubmit successful).