Add a ScheduledServer class.

Add a ScheduledServer class.

Committed: https://code.google.com/p/dart/source/detail?r=20042

[Bob Nystrom, 2013-03-13 21:02:34]

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
File pkg/scheduled_test/lib/scheduled_server.dart (right):

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_server.dart:45: var id = _count++;
Nit, but I think we should only increment the id when unnamed servers are
created. That way, creating a new server with a description doesn't shift the
ids of all later anonymous ones.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_server.dart:67: /// [path]. The schedule will
block until an HTTP request is received. If that
block -> wait

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_server.dart:70: /// will block until that
[Future] completes.
block -> wait

It's more or less equivalent, but I don't want people to think it literally
blocks.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_server.dart:96: "unexpectedly.";
"when no more requests were expected"

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/scheduled_server/handler.dart (right):

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/scheduled_server/handler.dart:30: final Task
_taskBefore = currentSchedule.tasks.contents.last;
Can you explain this? Why is .last the prior task?

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
File pkg/scheduled_test/test/scheduled_server_test.dart (right):

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
pkg/scheduled_test/test/scheduled_server_test.dart:33: completion(equals('Hello,
test!')));
What is this completion() expectation for? It will fail, won't it?

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
pkg/scheduled_test/test/scheduled_server_test.dart:41: expect(errors[1].error,
new isInstanceOf<HttpParserException>());
What's this for?

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
pkg/scheduled_test/test/scheduled_server_test.dart:92: // for the
immediately-preceding task.
I'd like to understand this better. Can we talk about it?

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
pkg/scheduled_test/test/scheduled_server_test.dart:122: // request won't take
1s.
:(

[nweiz, 2013-03-13 23:50:59]

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
File pkg/scheduled_test/lib/scheduled_server.dart (right):

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_server.dart:45: var id = _count++;
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> Nit, but I think we should only increment the id when unnamed servers are
> created. That way, creating a new server with a description doesn't shift the
> ids of all later anonymous ones.

I disagree. I think it's a more useful property that naming a
previously-anonymous server doesn't shift the ids of all later anonymous ones.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_server.dart:67: /// [path]. The schedule will
block until an HTTP request is received. If that
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> block -> wait

Done.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_server.dart:70: /// will block until that
[Future] completes.
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> block -> wait
> 
> It's more or less equivalent, but I don't want people to think it literally
> blocks.

Done.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/schedu...
pkg/scheduled_test/lib/scheduled_server.dart:96: "unexpectedly.";
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> "when no more requests were expected"

Done.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/scheduled_server/handler.dart (right):

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/scheduled_server/handler.dart:30: final Task
_taskBefore = currentSchedule.tasks.contents.last;
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> Can you explain this? Why is .last the prior task?

Explained in the doc comment.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
File pkg/scheduled_test/test/scheduled_server_test.dart (right):

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
pkg/scheduled_test/test/scheduled_server_test.dart:33: completion(equals('Hello,
test!')));
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> What is this completion() expectation for? It will fail, won't it?

I want this to look like a real test so we catch any usability issues that would
come up in real tests using ScheduledServer. In particular, expect(...,
completes) creates an out-of-band callback, and I want to make sure that doesn't
somehow cause a timeout.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
pkg/scheduled_test/test/scheduled_server_test.dart:41: expect(errors[1].error,
new isInstanceOf<HttpParserException>());
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> What's this for?

The request gets an HttpParserException because the server shuts down after
receiving an error.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
pkg/scheduled_test/test/scheduled_server_test.dart:92: // for the
immediately-preceding task.
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> I'd like to understand this better. Can we talk about it?

Done.

https://codereview.chromium.org/12809002/diff/1/pkg/scheduled_test/test/sched...
pkg/scheduled_test/test/scheduled_server_test.dart:122: // request won't take
1s.
On 2013/03/13 21:02:35, Bob Nystrom wrote:
> :(

If you've got a better idea, I'm all ears.

[Bob Nystrom, 2013-03-14 00:33:58]

LGTM.

[nweiz, 2013-03-14 18:20:15]

Committed patchset #2 manually as r20042 (presubmit successful).